Use key as main identity for button widgets#12332
Merged
lukasmasuch merged 22 commits intodevelopfrom Aug 29, 2025
Merged
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
lukasmasuch
added
security-assessment-completed
change:feature
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| element_id = compute_and_register_element_id( | ||
| "button", | ||
| user_key=key, | ||
| key_as_main_identity=True, |
Collaborator
There was a problem hiding this comment.
Only the buttons are configured as true here.
…as-identity-for-buttons
…as-identity-for-buttons
| ) | ||
|
|
||
|
|
||
| def test_dynamic_button(app: Page, assert_snapshot: ImageCompareFunction): |
Collaborator
There was a problem hiding this comment.
note: Seems like there is a snapshot mismatch for this test in CI.
Collaborator
Author
There was a problem hiding this comment.
seems to be some sub-pixel screenshot flakiness with firefox :( pushed an attempt to fix it
| expect(submit_button).to_be_visible() | ||
|
|
||
|
|
||
| def test_dynamic_submit_button(app: Page, assert_snapshot: ImageCompareFunction): |
Collaborator
There was a problem hiding this comment.
note: Seems like there is a snapshot mismatch for this test in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
If a custom
keyis passed to any of the button widgets -st.button,st.download_button,st.form_submit_button- it will be used as the main identity. This allows for dynamically changing other parameters in between reruns without causing the widgets to be recreated in the frontend.GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.