Add enhancement proposal process#12248
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ PR preview is ready!
|
lukasmasuch
added
security-assessment-completed
change:other
lukasmasuch
changed the title
| Check the boxes or add a comment with the reason it cannot be checked. | ||
| --> | ||
|
|
||
| - [ ] Works on all deployment platforms (e.g. [Streamlit Community Cloud](https://streamlit.io/cloud), [Streamlit in Snowflake](https://www.snowflake.com/en/product/features/streamlit-in-snowflake/), [Hugging Face Spaces](https://huggingface.co/spaces))? |
There was a problem hiding this comment.
question/nit: Do you mean, "should this work on all platforms?" or "will this work on all platforms?" When I read this, it sounds to me like it's already built and should work on all deployment platforms.
There was a problem hiding this comment.
The question is about checking it we can come up with reasons at speccing time why this might be problematic on a specific platform. So it's more about "will this work on all platforms". I can also clarify this slightly more.
| - Keep the PR in Draft until it’s ready for discussion | ||
| 4. When ready, mark the PR "Ready for review" on GitHub. All discussion on the spec | ||
| should happen on the PR. | ||
| 5. Merging requires at least two approvals from core maintainers. |
There was a problem hiding this comment.
question: What is the significance of merging a spec? Does this mean it's ready to be worked on? Can specs be merged in status: draft?
There was a problem hiding this comment.
I think for now we only plan to merge approved/ready specs. Specs in draft are just open PRs. I can clarify this a bit more
sfc-gh-nbellante
left a comment
sfc-gh-nbellante
left a comment
There was a problem hiding this comment.
Couple q's but otherwise LGTM!
|
@sfc-gh-nbellante sorry, PR was on auto-merge. I will address the comments in a follow up |
👌 |
## Describe your changes Applies some feedback from #12248 which couldn't be incorporated since the PR was set to auto-merge. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
5 participants
Describe your changes
Adds lightweight process that allows anyone to contribute and discuss enhancement proposals for Streamlit.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.