[fix] Fullscreen behaviour for st.image with use_container_width=True or width="stretch"#12235
Merged
sfc-gh-lwilby merged 3 commits intodevelopfrom Aug 22, 2025
Conversation
Contributor
✅ PR preview is ready!
|
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sfc-gh-lwilby
added
security-assessment-completed
change:bugfix
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the fullscreen behavior for st.image components that use width="stretch" or use_container_width=True. Previously, images with these width configurations would not properly expand to fill the available screen space when viewed in fullscreen mode.
- Adds
shouldStretchprop to styled components to control width behavior in fullscreen mode - Updates the
Imagecomponent to pass through the stretch configuration - Adds E2E test coverage for fullscreen behavior with stretched images
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/lib/src/components/elements/ImageList/styled-components.ts | Adds shouldStretch prop to control width and flex-grow behavior for stretched images |
| frontend/lib/src/components/elements/ImageList/ImageList.tsx | Implements logic to determine when images should stretch and passes the prop through components |
| e2e_playwright/st_image_test.py | Adds test case for fullscreen behavior with width='stretch' images |
sfc-gh-bnisco
approved these changes
Aug 22, 2025
sfc-gh-lwilby
deleted the
fix/image-with-width-stretch-use-container-width-fullscreen
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
When an image has
width="stretch"oruse_container_width=True, then it should expand in full screen mode, filling the screen as much as it can while still maintaining its proportions.GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.