Skip to content

Missing module in pipfile#1222

Merged
jrhone merged 2 commits intostreamlit:developfrom
jrhone:import_packaging
Mar 18, 2020
Merged

Missing module in pipfile#1222
jrhone merged 2 commits intostreamlit:developfrom
jrhone:import_packaging

Conversation

@jrhone
Copy link
Copy Markdown
Contributor

@jrhone jrhone commented Mar 17, 2020

No description provided.

@jrhone jrhone added the WIP label Mar 17, 2020
@jrhone jrhone requested a review from a team as a code owner March 17, 2020 01:58
@jrhone jrhone removed the WIP label Mar 18, 2020
@kantuni
Copy link
Copy Markdown
Collaborator

kantuni commented Mar 18, 2020

Why do we need this package?

@jrhone
Copy link
Copy Markdown
Contributor Author

jrhone commented Mar 18, 2020

We use it in version.py and in our tests but mysteriously it wasn't triggering an error in the tests, only when running streamlit --version

@jrhone jrhone merged commit bd68fed into streamlit:develop Mar 18, 2020
sthagen added a commit to sthagen/streamlit-streamlit that referenced this pull request Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants