Another attempt at test_multiple_scriptrunners timeouts#1211
Merged
tconkling merged 3 commits intostreamlit:developfrom Mar 10, 2020
Merged
Another attempt at test_multiple_scriptrunners timeouts#1211tconkling merged 3 commits intostreamlit:developfrom
tconkling merged 3 commits intostreamlit:developfrom
Conversation
- Shutdown the first scriptrunner before starting the next 3 - Longer infinite-loop sleep time in widgts_script.py, so we don't wake up too frequently - Increase our wait_for_widgets_script_deltas timeout to 15 seconds (from 5) - Throw an error from wait_for_widgets_script_deltas, instead of just printing, so that the error is clearer.
arraydude
approved these changes
Mar 10, 2020
nthmost
approved these changes
Mar 10, 2020
Contributor
nthmost
left a comment
nthmost
left a comment
There was a problem hiding this comment.
godspeed on this, hope it works
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Mar 10, 2020
* develop: Another attempt at test_multiple_scriptrunners timeouts (streamlit#1211)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Mar 10, 2020
* develop: file_uploader: support for multiple files (streamlit#1183) Another attempt at test_multiple_scriptrunners timeouts (streamlit#1211)
tvst
reviewed
Mar 11, 2020
| This is meant to deflake tests that previously depended on timing to ensure | ||
| we had all the deltas we needed. | ||
| def require_widgets_deltas( | ||
| runners: List[TestScriptRunner], timeout: float = 15 |
Contributor
There was a problem hiding this comment.
Remove the timeout argument since it's never used. Just set it internally to 15.0 instead.
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Mar 11, 2020
* develop: Better error messages for st.cache (streamlit#1146) Fix st.cache (streamlit#1208) file_uploader: support for multiple files (streamlit#1183) Another attempt at test_multiple_scriptrunners timeouts (streamlit#1211) Speed up `make jstest` on CircleCI De-flake ScriptRunner_test.py (streamlit#1195)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.