Adding support for if and for to magic #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvst
approved these changes
Aug 26, 2019
| # Parse the contents of functions, With statements, and for statements | ||
| if (node_type is ast.FunctionDef or node_type is ast.With or | ||
| node_type is ast.For): | ||
| _modify_ast_subtree(node) |
Contributor
There was a problem hiding this comment.
Bringing the conversation from the old repo in here:
tvst 3 days ago
You removed the body[i] = thing. Are you sure that's not needed? (i.e. is node always being modified in-place?)
monchier 3 days ago
Yeah, I was about to add a note. From some tests seems it is not. You have a specific case in mind? _modify_ast_subtree should recurse and node is an object, so it is mutated.
Actually I think you're right. That part of the code is probably no longer needed. We used to do some heavier AST modifications that did not mutate the original nodes, but from a quick pass it looks like they're gone now.
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Aug 27, 2019
* develop: st.map() using deck_gl (streamlit#14) Adding support for if and for to magic (streamlit#12) Fix vertical spacing in Streamlit reports (streamlit#7) Fix streamlit#6: report should loads element by element (was broken since Sidebar PR) (streamlit#9)
tvst
added a commit
that referenced
this pull request
Sep 14, 2021
* Make h1 bolder by adding extrabold font. * Reduce base font to 16px again. * Make h1 a little bigger. * Set vertical rhythm in headers (always add to integer rems). Stop using margin so no need to tweak first-child case. * Make headers in sidebar smaller (i.e. undo previous change). * Add more space to report top. * Improve vertical rhythm on st.metric * Add typography e2e test. Screenshots coming in next PR. * Fix JS snapshot test. * Add name for 1.125rem font. * Fix typography test spec
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as on old branch: https://github.com/streamlit/streamlit-old-private/pull/1271