Skip to content

Pypi nightly builds#1171

Merged
jrhone merged 74 commits intostreamlit:developfrom
jrhone:pypi_nightly
Mar 6, 2020
Merged

Pypi nightly builds#1171
jrhone merged 74 commits intostreamlit:developfrom
jrhone:pypi_nightly

Conversation

@jrhone
Copy link
Copy Markdown
Contributor

@jrhone jrhone commented Mar 2, 2020

@jrhone jrhone requested a review from a team as a code owner March 2, 2020 16:27
"analyze": "source-map-explorer 'build/static/js/*.js'",
"start": "export NODE_OPTIONS=--max_old_space_size=4096 && craco start",
"build": "export NODE_OPTIONS=--max_old_space_size=4096 && craco build",
"build": "export NODE_OPTIONS=--max_old_space_size=6144 && craco build",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: revert this change

# Combine [packages] with either [python3] or [python2]
packages = pipfile["packages"].copy()
if version_info.major == 2:
if sys.version_info.major == 2:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's needed but I'll leave it for now since @nthmost is working on removing python 2 stuff in #1177

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that'll get pulled out today.


import mock
import requests_mock
from packaging.version import Version as pkg_version
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As pkg_version is a class, shouldn't the name be PkgVersion? (not to confuse it with function)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Copy link
Copy Markdown
Collaborator

@kantuni kantuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrhone jrhone merged commit 329604f into streamlit:develop Mar 6, 2020
sthagen added a commit to sthagen/streamlit-streamlit that referenced this pull request Mar 6, 2020
tconkling added a commit to tconkling/streamlit that referenced this pull request Mar 9, 2020
* develop:
  Unpin python-dateutil package version (streamlit#1153)
  Pypi nightly builds (streamlit#1171)
  Adding custom filterOptions function to SelectBox (streamlit#1182)
  Expire media files when ReportSession expires (streamlit#1128)
  1159/use_container_width (streamlit#1174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants