Skip to content

Fix hashing if the object has a name but the name is not a string.#117

Merged
domoritz merged 3 commits intostreamlit:developfrom
domoritz:fix-115
Sep 17, 2019
Merged

Fix hashing if the object has a name but the name is not a string.#117
domoritz merged 3 commits intostreamlit:developfrom
domoritz:fix-115

Conversation

@domoritz
Copy link
Copy Markdown
Contributor

@domoritz domoritz commented Sep 16, 2019

Fixes #115

@domoritz domoritz changed the title Fix hashing is the object has a name but it's not a string. Fix hashing if the object has a name but it's not a string. Sep 16, 2019
@domoritz domoritz changed the title Fix hashing if the object has a name but it's not a string. Fix hashing if the object has a name but the name is not a string. Sep 16, 2019
Copy link
Copy Markdown
Contributor

@tvst tvst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this fix?

@domoritz domoritz merged commit ee4c4fa into streamlit:develop Sep 17, 2019
@domoritz domoritz deleted the fix-115 branch September 17, 2019 00:22
tconkling added a commit to tconkling/streamlit that referenced this pull request Sep 17, 2019
# By Nahuel Emiliano Rosso Fandiño (3) and others
# Via GitHub
* develop:
  Fixing unbound local variable (streamlit#110)
  Support hashing dataframes with unhashable objects. Gracefully f… (streamlit#118)
  Fix hashing if the object has a name but the name is not a string. (streamlit#117)
  Fixed marshalling images with Alpha channel (streamlit#109)
  Adding `streamlit run` by url (streamlit#99)
  Fixed broken websocket when reconnect (streamlit#105)

# Conflicts:
#	lib/tests/streamlit/cli_test.py
tconkling added a commit to tconkling/streamlit that referenced this pull request Sep 23, 2019
* develop: (54 commits)
  Removing uber demo from streamlit repo (streamlit#159)
  Release 0.46.0 (streamlit#170)
  Magic fixes (streamlit#138)
  [docs] Add analytics; redirect /secret/docs; fix compilation problem (streamlit#149)
  Fix bug for startup under windows (streamlit#144)
  Responsive layout (streamlit#104)
  Add basic PR template
  Better method signatures (streamlit#88)
  Publish docs to both /docs and /secret/docs, until we deprecate /secret/docs in January. (streamlit#141)
  Rename/report2app (streamlit#126)
  Test running streamlit commands "bare" (streamlit#133)
  Updates to LP and sidebar. (streamlit#134)
  tests for z-index of date input popover in sidebar (streamlit#131)
  cypress test for escaping html in markdown (streamlit#125)
  On a Mac, check if xcode installed before requiring watchdog (streamlit#91)
  [Docs] Fix st.slider API in tutorial (streamlit#98)
  Sidebar exceptions (streamlit#107)
  Fixing unbound local variable (streamlit#110)
  Support hashing dataframes with unhashable objects. Gracefully f… (streamlit#118)
  Fix hashing if the object has a name but the name is not a string. (streamlit#117)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to create Pandas Series in cached functions

2 participants