Improved new-lines handling for markdown text with background color#11530
Merged
lukasmasuch merged 2 commits intodevelopfrom Jun 6, 2025
Merged
Improved new-lines handling for markdown text with background color#11530lukasmasuch merged 2 commits intodevelopfrom
lukasmasuch merged 2 commits intodevelopfrom
Conversation
Contributor
✅ PR preview is ready!
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the background color handling for multi-line markdown text by modifying the styling of markdown components.
- Added the CSS property boxDecorationBreak: "clone" to ensure proper background rendering across broken lines.
Comments suppressed due to low confidence (1)
frontend/lib/src/components/shared/StreamlitMarkdown/styled-components.ts:263
- Consider verifying cross-browser support for 'boxDecorationBreak: "clone"' and add vendor prefixes if necessary to ensure consistent behavior across different browsers.
boxDecorationBreak: "clone",
lukasmasuch
added
security-assessment-completed
change:other
lukasmasuch
changed the title
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sfc-gh-lwilby
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Papercut to add better multi-line wrapping in markdown with text that has a background color.
Before:
After:
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.