[AdvancedLayouts] Adds a width parameter to st.title, st.subheader, and st.header#11490
[AdvancedLayouts] Adds a width parameter to st.title, st.subheader, and st.header#11490sfc-gh-lwilby merged 6 commits intodevelopfrom
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
✅ PR preview is ready!
|
sfc-gh-lwilby
added
security-assessment-completed
change:feature
There was a problem hiding this comment.
This is not expected, but I am assuming there is some subtle shift in this snapshot because there is an st.header element above it. I don't see a noticeable difference.
sfc-gh-lwilby
changed the title
|
|
||
|
|
||
| def test_heading_widths_snapshot( | ||
| themed_app: Page, assert_snapshot: ImageCompareFunction |
There was a problem hiding this comment.
nit: I think we can also use app here to lower the number of snapshots since the tested logic in this case shouldn't be influenced by the theme.
lukasmasuch
left a comment
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍 Maybe one aspect to check is if everything also works fine if the header has a tooltip (via help). Probably enough to verify this manually or add help to one of the existing command calls.
Checked this. |
2 participants
Describe your changes
This PR is part of the [AdvancedLayouts] project and introduces a new width parameter to heading elements.
GitHub Issue Link (if applicable)
#8197
Testing Plan
Unit Tests (JS and/or Python) ✅
E2E Tests ✅
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.