[refactor] Upgrade to eslint v9 and flat config#11446
Merged
sfc-gh-bnisco merged 13 commits intodevelopfrom May 28, 2025
Merged
[refactor] Upgrade to eslint v9 and flat config#11446sfc-gh-bnisco merged 13 commits intodevelopfrom
sfc-gh-bnisco merged 13 commits intodevelopfrom
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
1e2287b to
1fa8ad5
Compare
lukasmasuch
reviewed
May 27, 2025
lukasmasuch
approved these changes
May 27, 2025
Collaborator
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍 do we lose anything important with the removal of the airbnb eslint rule set?
sfc-gh-lmasuch
approved these changes
May 27, 2025
sfc-gh-nbellante
approved these changes
May 27, 2025
Collaborator
Author
|
@lukasmasuch good question re: Airbnb rule set. I took a look at this and I actually think the previous setup is misconfigured and thus isn't actually leveraging most of the base Airbnb rules. Per the directions we should have had both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
eslint-disabledirective in code. This PR removes any unusedeslint-disablescatchstatement. For now, I've disabled any existing violationseslint-disabledirectives for those.GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.