Skip to content

Add logging if cookie content is too large#11290

Merged
kajarenc merged 1 commit intodevelopfrom
add-logger-call-due-to-11168
May 8, 2025
Merged

Add logging if cookie content is too large#11290
kajarenc merged 1 commit intodevelopfrom
add-logger-call-due-to-11168

Conversation

@kajarenc
Copy link
Copy Markdown
Contributor

@kajarenc kajarenc commented May 6, 2025

Describe your changes

Add log error if the Auth cookie content is too large

GitHub Issue Link (if applicable)

Related to #11168

Testing Plan

  • Explanation of why no additional tests are needed: Just logging added.
  • Unit Tests (JS and/or Python)
  • E2E Tests
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 6, 2025

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-11290/streamlit-1.45.0-py3-none-any.whl
🕹️ Preview app pr-11290.streamlit.app (☁️ Deploy here if not accessible)

@kajarenc kajarenc added security-assessment-completed impact:users PR changes affect end users change:chore PR contains maintenance or housekeeping change labels May 6, 2025
@kajarenc kajarenc marked this pull request as ready for review May 6, 2025 23:43
@snyk-io
Copy link
Copy Markdown
Contributor

snyk-io bot commented May 7, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@kajarenc kajarenc requested a review from Copilot May 7, 2025 10:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds logging when the authentication cookie content exceeds the 4096-byte limit, aiming to help diagnose potential issues with cookie sizes.

  • Logs an error if the serialized cookie value is too large
  • Leaves the cookie setting behavior unchanged

Copy link
Copy Markdown
Collaborator

@mayagbarnes mayagbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mayagbarnes mayagbarnes self-assigned this May 7, 2025
@kajarenc kajarenc merged commit bab3f99 into develop May 8, 2025
38 of 40 checks passed
@kajarenc kajarenc deleted the add-logger-call-due-to-11168 branch May 8, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:chore PR contains maintenance or housekeeping change impact:users PR changes affect end users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants