Ensure filename extension check is normalized#11261
Merged
Conversation
kmcgrady
added
security-assessment-completed
change:bugfix
Contributor
✅ PR preview is ready!
|
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sfc-gh-bnisco
approved these changes
May 5, 2025
2 tasks
sfc-gh-mbarnes
pushed a commit
that referenced
this pull request
May 12, 2025
## Describe your changes We have a bug where the filename has an uppercase extension that did not pass the file extension enforcement and caused issues. This ensures we are checking the lowercase filename. ## GitHub Issue Link (if applicable) closes #11259 ## Testing Plan - Python unit tests updated --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
We have a bug where the filename has an uppercase extension that did not pass the file extension enforcement and caused issues. This ensures we are checking the lowercase filename.
GitHub Issue Link (if applicable)
closes #11259
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.