[AdvancedLayouts] Adds a width parameter to st.metric#11159
Merged
sfc-gh-lwilby merged 17 commits intodevelopfrom Jun 5, 2025
Merged
[AdvancedLayouts] Adds a width parameter to st.metric#11159sfc-gh-lwilby merged 17 commits intodevelopfrom
sfc-gh-lwilby merged 17 commits intodevelopfrom
Conversation
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
sfc-gh-lwilby
added
security-assessment-completed
change:feature
sfc-gh-lwilby
force-pushed
the
feature/add-width-to-metric
branch
from
f408283 to
0c6eeff
Compare
sfc-gh-lwilby
changed the title
sfc-gh-lwilby
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
lukasmasuch
reviewed
Jun 5, 2025
Comment on lines
+148
to
+180
| def test_stretch_width(themed_app: Page, assert_snapshot: ImageCompareFunction): | ||
| """Test that stretch width works correctly.""" | ||
| metric_element = themed_app.get_by_test_id("stMetric").nth(12) | ||
| expect(metric_element.get_by_test_id("stMetricLabel")).to_have_text("Stretch width") | ||
|
|
||
| assert_snapshot( | ||
| metric_element, | ||
| name="st_metric-stretch_width", | ||
| ) | ||
|
|
||
|
|
||
| def test_pixel_width(themed_app: Page, assert_snapshot: ImageCompareFunction): | ||
| """Test that pixel width works correctly.""" | ||
| metric_element = themed_app.get_by_test_id("stMetric").nth(13) | ||
| expect(metric_element.get_by_test_id("stMetricLabel")).to_have_text( | ||
| "Pixel width (300px)" | ||
| ) | ||
|
|
||
| assert_snapshot( | ||
| metric_element, | ||
| name="st_metric-pixel_width", | ||
| ) | ||
|
|
||
|
|
||
| def test_content_width(themed_app: Page, assert_snapshot: ImageCompareFunction): | ||
| """Test that content width works correctly.""" | ||
| metric_element = themed_app.get_by_test_id("stMetric").nth(14) | ||
| expect(metric_element.get_by_test_id("stMetricLabel")).to_have_text("Content width") | ||
|
|
||
| assert_snapshot( | ||
| metric_element, | ||
| name="st_metric-content_width", | ||
| ) |
Collaborator
There was a problem hiding this comment.
nit: same as in the other PRs, I think we can use app here to lower the number of snapshots and test runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR is part of the [AdvancedLayouts] project and introduces a new width parameter to metric elements.
GitHub Issue Link (if applicable)
#8197
Testing Plan
Unit Tests (JS and/or Python) ✅
E2E Tests ✅
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.