[Fix] FE validation for st.date_input#10764
Merged
mayagbarnes merged 13 commits intodevelopfrom Apr 8, 2025
Merged
Conversation
mayagbarnes
added
security-assessment-completed
change:bugfix
sfc-gh-mbarnes
force-pushed
the
fix-8475
branch
from
1f46254 to
07a76be
Compare
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
mayagbarnes
changed the title
st.date_inputst.date_input
sfc-gh-bnisco
approved these changes
Apr 8, 2025
Collaborator
sfc-gh-bnisco
left a comment
sfc-gh-bnisco
left a comment
There was a problem hiding this comment.
Awesome, thank you!
Closed
4 tasks
4 tasks
sfc-gh-bnisco
added a commit
that referenced
this pull request
Aug 22, 2025
#12295) ## Describe your changes - Problem: BaseWeb’s quick select returns midday-anchored Date objects (12:00), while our min/max bounds are midnight. Our validation compared full datetimes, so same-day end dates were flagged as > max. - Changes: - Normalize all selected dates to `00:00` in `handleChange` before validation and state updates. - Normalize stored values in `updateWidgetMgrState` before validation. - Tests: - Add unit test asserting a quick-select range ending "today" is accepted with `max` set to today and no error icon is shown. - Stabilize time by mocking `moment.now` and `Date`, avoiding fake timers that interfere with BaseWeb popovers. ## GitHub Issue Link (if applicable) Fixes #12293 Ref #10166, #10764 ## Testing Plan - ✅ Unit Tests (JS and/or Python) --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add FE input validation to
st.date_input- render an error tooltip & input in error state when dates outside min/max range, also don't commit a value if not within range.Error State:
Light:
Dark:
GitHub Issue Link (if applicable)
Closes #8475
Testing Plan