Activate Pandas linting rules (PD)#10571
Merged
lukasmasuch merged 2 commits intodevelopfrom Mar 3, 2025
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sfc-gh-lmasuch
added
security-assessment-completed
change:other
sfc-gh-lmasuch
changed the title
sfc-gh-lmasuch
changed the title
lukasmasuch
changed the title
lukasmasuch
changed the title
lukasmasuch
changed the title
sfc-gh-bnisco
approved these changes
Mar 3, 2025
lukasmasuch
added a commit
that referenced
this pull request
Sep 10, 2025
## Describe your changes The change to use `iloc` instead of `iat` applied in #10571 caused performance issues. This PR fixes the performance issues by using a more efficient way to update the values in the dataframe. ## GitHub Issue Link (if applicable) - Related #10952 ## Testing Plan - Existing tests should cover this well. - Added a benchmark test to keep track of the styler performance. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license. --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Lukas Masuch <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Activates the pandas linting category in ruff (PD). This provides a couple of opinionated linting rules for usage of the Pandas API. We ignore this rule in our tests since our tests do not need the same scrutiny.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.