Skip to content

[Fix] Reuse event loop logic #10455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mayagbarnes merged 1 commit into from
Feb 20, 2025
Merged

[Fix] Reuse event loop logic #10455

mayagbarnes merged 1 commit into from
Feb 20, 2025

Conversation

@mayagbarnes
Copy link
Collaborator

@mayagbarnes mayagbarnes commented Feb 20, 2025

Describe your changes

asyncio.get_running_loop() throws a RuntimeError: There is no current event loop in thread 'MainThread' when this is no current event loop.

Resolves issue introduced in #10164.

GitHub Issue Link (if applicable)

Closes #10452

Testing Plan

  • Unit Tests (JS and/or Python): Added ✅
  • Manual Testing: ✅

@mayagbarnes mayagbarnes added security-assessment-completed Security assessment has been completed for PR change:bugfix PR contains bug fix implementation impact:users PR changes affect end users labels Feb 20, 2025
@mayagbarnes mayagbarnes mentioned this pull request Feb 20, 2025
Closed
4 tasks
@mayagbarnes mayagbarnes marked this pull request as ready for review February 20, 2025 01:55
raethlein
raethlein approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@raethlein raethlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mayagbarnes mayagbarnes merged commit 68f9db9 into develop Feb 20, 2025
44 checks passed
@mayagbarnes mayagbarnes deleted the event-loop-fix branch February 20, 2025 17:43
sfc-gh-mbarnes pushed a commit that referenced this pull request Feb 20, 2025
@mayagbarnes
[Fix] Reuse event loop logic (#10455)
0805aa3 
`asyncio.get_running_loop()` throws a `RuntimeError: There is no current event loop in thread 'MainThread'` when this is no current event loop.
Resolves issue introduced in PR #10164. Closes #10452
sfc-gh-mbarnes pushed a commit that referenced this pull request Feb 20, 2025
@mayagbarnes
[Fix] Reuse event loop logic (#10455)
6e747f9 
`asyncio.get_running_loop()` throws a `RuntimeError: There is no current event loop in thread 'MainThread'` when this is no current event loop.
Resolves issue introduced in PR #10164. Closes #10452
@SnakeRelatedBusiness SnakeRelatedBusiness mentioned this pull request Mar 24, 2025
Closed
@peterthelander peterthelander mentioned this pull request Jul 2, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raethlein raethlein raethlein approved these changes

Assignees

No one assigned

Labels

change:bugfix PR contains bug fix implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v1.42.0 introduces call to asyncio.get_event_loop().is_running() which sometimes throws RuntimeError

3 participants

@mayagbarnes @raethlein