Skip to content

Conversation

@raethlein
Copy link
Collaborator

Describe your changes

Revert #10073 because @lukasmasuch and @jrieke detected an issue with it.

GitHub Issue Link (if applicable)

Testing Plan

  • Explanation of why no additional tests are needed
  • Unit Tests (JS and/or Python)
  • E2E Tests
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@raethlein raethlein changed the title Revert PR https://github.com/streamlit/streamlit/pull/10073 Revert PR-10073: Preserve scrollposition for selectbox and multiselect Jan 23, 2025
Copy link
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@raethlein raethlein added security-assessment-completed Security assessment has been completed for PR impact:internal PR changes only affect internal code change:bugfix PR contains bug fix implementation labels Jan 23, 2025
@raethlein raethlein merged commit 05065fc into develop Jan 23, 2025
41 of 44 checks passed
@lukasmasuch lukasmasuch deleted the fix/revert-scrollposition-for-selectbox-multiselect branch March 13, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:bugfix PR contains bug fix implementation impact:internal PR changes only affect internal code security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants