Add support for using categorical index with st.data_editor
#10195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmasuch
changed the title
st.data_editorst.data_editor
lukasmasuch
added
security-assessment-completed
raethlein
approved these changes
Jan 16, 2025
Collaborator
raethlein
left a comment
raethlein
left a comment
There was a problem hiding this comment.
Awesome 🚀
Was is the sum of changes or one particular change that enabled this?
Collaborator
Author
The refactoring moved the parsing of categorical options to the parsing process and added those options to the column type info during quiver initialization, which makes these options accessible to index & data columns. The previous implementation extracted the options after quiver initialization, and that didn't had access to the required props anymore to get this for index columns. |
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
…lit#10195) ## Describe your changes The recent refactorings made it possible to use categorical index columns with `st.data_editor`. This PR removes the previous restrictions. ## GitHub Issue Link (if applicable) - Closes streamlit#9647 ## Testing Plan - Add e2e snapshot test and updated unit tests. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The recent refactorings made it possible to use categorical index columns with
st.data_editor. This PR removes the previous restrictions.GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.