Print st.logo only on first page on the top #10171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raethlein
force-pushed
the
fix/print-logo-10165
branch
from
4c58fc7 to
e8147a8
Compare
raethlein
added
security-assessment-completed
raethlein
force-pushed
the
fix/print-logo-10165
branch
from
94cd4c0 to
ee2ce89
Compare
raethlein
changed the title
lukasmasuch
reviewed
Jan 13, 2025
Collaborator
There was a problem hiding this comment.
Should we be more specific to target the img of the logo only?
Collaborator
Author
There was a problem hiding this comment.
Good point, I have updated the selector to use the stLogo test id. Does this sound good?
Collaborator
There was a problem hiding this comment.
Instead of test-id, it would be better to use a proper class or we could directly link to StyledLogo here (preferred) like its done here:
Collaborator
Author
There was a problem hiding this comment.
Great hint, I have updated it to [`& > ${StyledLogo}`]
raethlein
force-pushed
the
fix/print-logo-10165
branch
from
968c68b to
2f420e9
Compare
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
## Describe your changes Closes streamlit#10165 Fixes the printing layout of `st.logo`. Right now it shows on the side (see streamlit#10165) but with this change it will show on the top left and only on the first page. This PR adds the Streamlit logo to the e2e version of the `hello_app` test so that the logo printing is tested. ## GitHub Issue Link (if applicable) ## Testing Plan - E2E Tests - Add `st.logo` to the `hello_app` e2e test to ensure that printing is working as expected --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #10165
Fixes the printing layout of
st.logo. Right now it shows on the side (see #10165) but then it will show on the top left and only on the first page.This PR adds the Streamlit logo to the e2e version of the
hello_apptest so that the logo printing is tested.Portrait:
Landscape:
GitHub Issue Link (if applicable)
Testing Plan
st.logoto thehello_appe2e test to ensure that printing is working as expectedContribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.