Make MPAv2 work with pure Python and with ProcessPoolExecutor #10163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgrady
added
security-assessment-completed
kmcgrady
approved these changes
Jan 14, 2025
Collaborator
kmcgrady
left a comment
kmcgrady
left a comment
There was a problem hiding this comment.
LGTM. Thanks for catching this!
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
…lit#10163) ## Describe your changes Today, when `st.navigation` is present in an app, any [code using `ProcessPoolExecutor`](https://discuss.streamlit.io/t/make-apps-faster-by-moving-heavy-computation-to-a-separate-process/68541#method-2-use-a-processpoolexecutor-5) will throw an exception. Turns out this is because `ProcessPoolExecutor` spins up a separate pure-Python process, and there's a bug that causes `st.navigation` not to work in pure-Python mode (it requires a ScriptRunContext). This wasn't caught before because our pure-Python tests (`make bare-execution-tests`) weren't actually running for scripts in _subfolders_ of the main test folder. ...and when you run those previously-untested tests you discover `st.page_link` _also_ doesn't work in pure-Python mode! So this PR addresses all of the above: 1. Makes `st.navigation` and `st.page_link` work in pure-Python mode -- and therefore also when running inside a `ProcessPoolExecutor` 2. Makes `bare-execution-tests` test MPAv1 and MPAv2 code ## GitHub Issue Link (if applicable) n/a ## Testing Plan - ~~Explanation of why no additional tests are needed~~ - Unit Tests (JS and/or Python): ❌ - E2E Tests: ✅ - Any manual testing needed? ❌ --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Today, when
st.navigationis present in an app, any code usingProcessPoolExecutorwill throw an exception. Turns out this is becauseProcessPoolExecutorspins up a separate pure-Python process, and there's a bug that causesst.navigationnot to work in pure-Python mode (it requires a ScriptRunContext).This wasn't caught before because our pure-Python tests (
make bare-execution-tests) weren't actually running for scripts in subfolders of the main test folder....and when you run those previously-untested tests you discover
st.page_linkalso doesn't work in pure-Python mode!So this PR addresses all of the above:
st.navigationandst.page_linkwork in pure-Python mode -- and therefore also when running inside aProcessPoolExecutorbare-execution-teststest MPAv1 and MPAv2 codeGitHub Issue Link (if applicable)
n/a
Testing Plan
Explanation of why no additional tests are neededContribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.