Remove protobuf version restriction in conda recipe #10159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgrady
added
security-assessment-completed
kmcgrady
changed the title
sfc-gh-vdonato
approved these changes
Jan 10, 2025
kmcgrady
added a commit
that referenced
this pull request
Jan 13, 2025
## Describe your changes We restricted protobuf due to issues in conda, but we have since upgraded protobuf. We should have it mimic reality. For this, we should try to not get involved and let the setup.py dictate. Assuming the Conda build succeeds, then new versions should be better and we can undo the check. ## Testing Plan - Conda Build should pass --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
kmcgrady
added a commit
that referenced
this pull request
Jan 13, 2025
## Describe your changes We restricted protobuf due to issues in conda, but we have since upgraded protobuf. We should have it mimic reality. For this, we should try to not get involved and let the setup.py dictate. Assuming the Conda build succeeds, then new versions should be better and we can undo the check. ## Testing Plan - Conda Build should pass --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
## Describe your changes We restricted protobuf due to issues in conda, but we have since upgraded protobuf. We should have it mimic reality. For this, we should try to not get involved and let the setup.py dictate. Assuming the Conda build succeeds, then new versions should be better and we can undo the check. ## Testing Plan - Conda Build should pass --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We restricted protobuf due to issues in conda, but we have since upgraded protobuf. We should have it mimic reality. For this, we should try to not get involved and let the setup.py dictate. Assuming the Conda build succeeds, then new versions should be better and we can undo the check.
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.