Skip to content

Conversation

@sfc-gh-bnisco
Copy link
Collaborator

Describe your changes

  • Fixes a name collision with existing playwright-e2e-tests job

GitHub Issue Link (if applicable)

Testing Plan

  • This is a workflow change

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-bnisco sfc-gh-bnisco added security-assessment-completed Security assessment has been completed for PR impact:internal PR changes only affect internal code change:bugfix PR contains bug fix implementation labels Jan 9, 2025
@sfc-gh-bnisco sfc-gh-bnisco marked this pull request as ready for review January 9, 2025 17:42
@sfc-gh-bnisco sfc-gh-bnisco requested review from a team and mayagbarnes as code owners January 9, 2025 17:42
Copy link
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfc-gh-bnisco sfc-gh-bnisco merged commit 7dccdb8 into develop Jan 9, 2025
43 of 47 checks passed
@sfc-gh-bnisco sfc-gh-bnisco deleted the bnisco/rename-playwright-performance branch January 9, 2025 17:55
edegp pushed a commit to edegp/streamlit that referenced this pull request Jan 19, 2025
## Describe your changes

- Fixes a name collision with existing `playwright-e2e-tests` job

## GitHub Issue Link (if applicable)

## Testing Plan

- This is a workflow change

---

**Contribution License Agreement**

By submitting this pull request you agree that all contributions to this
project are made under the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:bugfix PR contains bug fix implementation impact:internal PR changes only affect internal code security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants