Refactor label_markdown e2e test for better testing of markdown features
#10141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmasuch
added
security-assessment-completed
lukasmasuch
changed the title
label_markdown e2e test
lukasmasuch
changed the title
label_markdown e2e testlabel_markdown e2e test for better testing of markdown features
raethlein
approved these changes
Jan 13, 2025
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
…tures (streamlit#10141) ## Describe your changes The `label_markdown` e2e test was quite annoying since it contains hundreds of snapshots across various that required repeated updates for unrelated changes. This PR refactors this test and improves our capabilities of testing markdown features by checking the underlying DOM elements instead of relying on screenshots. It also adds a screenshot test to every individual element test to check that the element correctly supports markdown in labels. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
label_markdowne2e test was quite annoying since it contains hundreds of snapshots across various that required repeated updates for unrelated changes.This PR refactors this test and improves our capabilities of testing markdown features by checking the underlying DOM elements instead of relying on screenshots. It also adds a screenshot test to every individual element test to check that the element correctly supports markdown in labels.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.