Skip to content

Conversation

@sfc-gh-bnisco
Copy link
Collaborator

@sfc-gh-bnisco sfc-gh-bnisco commented Jan 9, 2025

Describe your changes

  • Adds some more Playwright perf tests for some targeted areas in our application so we can use them as baselines moving forward

GitHub Issue Link (if applicable)

Testing Plan

  • This adds new performance tests

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-bnisco sfc-gh-bnisco added security-assessment-completed Security assessment has been completed for PR impact:internal PR changes only affect internal code change:chore PR contains maintenance or housekeeping change labels Jan 9, 2025
@sfc-gh-bnisco sfc-gh-bnisco force-pushed the bnisco/more-perf-tests branch from 8832a9a to 6d869b9 Compare January 9, 2025 17:06
@sfc-gh-bnisco sfc-gh-bnisco marked this pull request as ready for review January 9, 2025 17:42
Copy link
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfc-gh-bnisco sfc-gh-bnisco force-pushed the bnisco/more-perf-tests branch from 6d869b9 to 1c38e3b Compare January 9, 2025 18:54
@sfc-gh-bnisco sfc-gh-bnisco merged commit 70296a2 into develop Jan 9, 2025
33 checks passed
@sfc-gh-bnisco sfc-gh-bnisco deleted the bnisco/more-perf-tests branch January 9, 2025 19:52
edegp pushed a commit to edegp/streamlit that referenced this pull request Jan 19, 2025
## Describe your changes

- Adds some more Playwright perf tests for some targeted areas in our
application so we can use them as baselines moving forward

## GitHub Issue Link (if applicable)

## Testing Plan

- This adds new performance tests

---

**Contribution License Agreement**

By submitting this pull request you agree that all contributions to this
project are made under the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:chore PR contains maintenance or housekeeping change impact:internal PR changes only affect internal code security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants