Only show log but don't raise an error when fragment id is not found #10130
Conversation
raethlein
added
security-assessment-completed
raethlein
force-pushed
the
fix/issue-9921-only-emit-log
branch
from
3d93ba8 to
0abc3d8
Compare
There was a problem hiding this comment.
nit: can you add a comment here on what happens with the fragment request if an app runs into this? I assume the requested fragment rerun will just be ignored?
There was a problem hiding this comment.
Or maybe just add this info to the error message as well
There was a problem hiding this comment.
I have extended the comment above with a small preamble
There was a problem hiding this comment.
Oh I have just seen your second comment. Good idea, I have just updated the error message as well.
raethlein
force-pushed
the
fix/issue-9921-only-emit-log
branch
from
0abc3d8 to
29229ed
Compare
raethlein
force-pushed
the
fix/issue-9921-only-emit-log
branch
from
d115cff to
a791c39
Compare
…treamlit#10130) ## Describe your changes After the discussion in context of this PR: streamlit#9965, we want to show a log instead of raising an error in all cases to keep it simple and not introduce another list / more tech debt. ## GitHub Issue Link (if applicable) ## Testing Plan - Unit Tests (JS and/or Python) - Remove a couple of unit tests that checked for the exception to be thrown --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
|
I understand from the PR that a missing fragment is now ignored (instead of raising an error). Would it be possible to actually rerun the missing fragment if it is older than ~10 minutes? Why? When "installing" a Streamlit app from the browser (Chrome, "Add to start screen"), then fragments tend to be missing when the app is opened from the start screen after some 10 minutes after the app was first opened. |
Describe your changes
After the discussion in context of this PR: #9965, we want to show a log instead of raising an error in all cases to keep it simple and not introduce another list / more tech debt.
Changing this surfaced two race conditions that were subsequently tackled in #10132 and #10147
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.