Changes needed for public notebooks to record protobufs #10013
Merged
+69
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-nbellante
changed the title
sfc-gh-nbellante
added
security-assessment-completed
sfc-gh-nbellante
changed the title
sfc-gh-nbellante
changed the title
sfc-gh-nbellante
force-pushed
the
nico/public-notebooks
branch
from
f3e33c4 to
58b23a7
Compare
lukasmasuch
reviewed
Jan 8, 2025
raethlein
reviewed
Jan 8, 2025
raethlein
reviewed
Jan 8, 2025
sfc-gh-bnisco
approved these changes
Jan 9, 2025
lukasmasuch
reviewed
Jan 9, 2025
lukasmasuch
approved these changes
Jan 9, 2025
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
) ## Describe your changes These changes are needed for the public notebooks project and accomplishes two main things: 1. Introduces `ForwardMsgList` allowing us to store all of the protobuf messages as 1 protobuf message. 2. Adds a new lifecycle method that if set, will be called with the message before it is enqueued. But Nico! Why not utilize the newly added `ForwardMsgList` and avoid this base64 tomfoolery? Great question! It boils down wanting to be able to write the message as its enqueued. Why? For starters, it simplifies the code a bit to be able to just append these base64 lines, but more importantly, as we're recording these protobufs, we're watching this file and waiting for it to stop getting updates and using that to determine that the app is "done" rendering. ## Testing Plan Added a unit test for this new method. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
These changes are needed for the public notebooks project and accomplishes two main things:
ForwardMsgListallowing us to store all of the protobuf messages as 1 protobuf message.But Nico! Why not utilize the newly added
ForwardMsgListand avoid this base64 tomfoolery? Great question! It boils down wanting to be able to write the message as its enqueued. Why? For starters, it simplifies the code a bit to be able to just append these base64 lines, but more importantly, as we're recording these protobufs, we're watching this file and waiting for it to stop getting updates and using that to determine that the app is "done" rendering.Testing Plan
Added a unit test for this new method.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.