-
Notifications
You must be signed in to change notification settings - Fork 4k
Implement Caching object to support running code blocks only once #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvst
approved these changes
Aug 24, 2019
This was referenced Feb 19, 2023
2 tasks
4 tasks
4 tasks
4 tasks
2 tasks
sfc-gh-tteixeira
added a commit
that referenced
this pull request
Nov 22, 2024
This also changes some behavior: 1. When unsafe_allow_html=False AND _repr_html_() did not contain HTML tags we used to send its output to st.markdown(). This behavior is now removed. Instead, the output is handled like a normal object (that is, with st.help). 2. Removes _repr_html_ from *Connection objects. This didn't really buy us anything, and was just weird. Also, this was the reason for adding behavior #1 in the first place.
2 tasks
sfc-gh-lwilby
added a commit
that referenced
this pull request
Oct 19, 2025
…ions Addresses three suggestions from PR #12807 review: 1. Simplify test cases (suggestion #2) - Reduced from 9 parameterized tests to 3 focused tests - Removed fragment and expander contexts (regression only in containers) - Eliminated parameterization that made test app hard to read - Simple, clear structure with named containers 2. Add deterministic width assertions (suggestion #3) - stretch: Container width=600, expect ~580-600px (allows padding) - content: Figure 6.4in @ 100 DPI = 640px, expect ~620-640px - pixel: Explicit width=500, expect ~480-500px - More stable than arbitrary >200px threshold 3. Clean up unnecessary comments (suggestion #4) - Removed comments that just describe next line - Kept meaningful comments explaining test logic and expectations - Improved readability Test structure: - 3 regression tests in containers only - Specific figure size (6.4in x 4.8in at 100 DPI) - Known container width for stretch test - Deterministic assertions with reasonable margins Note: Suggestion #1 (use_container_width check) addressed with explanation in PR comment - current logic is correct for the new widthConfig system.
2 tasks
sfc-gh-lwilby
added a commit
that referenced
this pull request
Oct 20, 2025
Addressed suggestion #1 feedback: The suggestion to check use_container_width field revealed a TypeScript error - ImageList proto doesn't have useContainerWidth field (unlike chart elements). ImageList only has deprecated 'width' field (WidthBehavior enum). Current logic is correct: - When widthConfig is not set → default to stretch behavior (width: 100%) - When widthConfig.useStretch → use stretch behavior (width: 100%) - When widthConfig has other values → use auto width The legacy 'width' field (WidthBehavior enum) is handled by ImageList component itself, not by the container wrapper. The container just provides the outer width context. Updated comment to clarify this and explain the default legacy behavior.
4 tasks
sfc-gh-lwilby
added a commit
that referenced
this pull request
Oct 22, 2025
…ions Addresses three suggestions from PR #12807 review: 1. Simplify test cases (suggestion #2) - Reduced from 9 parameterized tests to 3 focused tests - Removed fragment and expander contexts (regression only in containers) - Eliminated parameterization that made test app hard to read - Simple, clear structure with named containers 2. Add deterministic width assertions (suggestion #3) - stretch: Container width=600, expect ~580-600px (allows padding) - content: Figure 6.4in @ 100 DPI = 640px, expect ~620-640px - pixel: Explicit width=500, expect ~480-500px - More stable than arbitrary >200px threshold 3. Clean up unnecessary comments (suggestion #4) - Removed comments that just describe next line - Kept meaningful comments explaining test logic and expectations - Improved readability Test structure: - 3 regression tests in containers only - Specific figure size (6.4in x 4.8in at 100 DPI) - Known container width for stretch test - Deterministic assertions with reasonable margins Note: Suggestion #1 (use_container_width check) addressed with explanation in PR comment - current logic is correct for the new widthConfig system.
sfc-gh-lwilby
added a commit
that referenced
this pull request
Oct 22, 2025
Addressed suggestion #1 feedback: The suggestion to check use_container_width field revealed a TypeScript error - ImageList proto doesn't have useContainerWidth field (unlike chart elements). ImageList only has deprecated 'width' field (WidthBehavior enum). Current logic is correct: - When widthConfig is not set → default to stretch behavior (width: 100%) - When widthConfig.useStretch → use stretch behavior (width: 100%) - When widthConfig has other values → use auto width The legacy 'width' field (WidthBehavior enum) is handled by ImageList component itself, not by the container wrapper. The container just provides the outer width context. Updated comment to clarify this and explain the default legacy behavior.
sfc-gh-aamadhavan
added a commit
that referenced
this pull request
Nov 6, 2025
sfc-gh-aamadhavan
added a commit
that referenced
this pull request
Nov 7, 2025
sfc-gh-aamadhavan
added a commit
that referenced
this pull request
Nov 9, 2025
sfc-gh-aamadhavan
added a commit
that referenced
this pull request
Nov 12, 2025
sfc-gh-aamadhavan
added a commit
that referenced
this pull request
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.