-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Use result.finalize to fix memory leak #755
Copy link
Copy link
Closed
Labels
type:enhancementRequests for feature enhancements or new featuresRequests for feature enhancements or new features
Description
Problem
Vega-Embed keeps references until you call result.finalize. We currently only call view.finalize.
Solution
Change https://github.com/streamlit/streamlit/blob/develop/frontend/src/components/elements/VegaLiteChart/VegaLiteChart.tsx#L283 to result.finalize as described in https://github.com/vega/vega-embed#embed.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type:enhancementRequests for feature enhancements or new featuresRequests for feature enhancements or new features