fix: handle EEXIST error when creating directories in parallel with node-to-fsa adapter#1205
Merged
streamich merged 3 commits intoOct 1, 2025
Merged
Conversation
Co-authored-by: streamich <[email protected]>
Copilot
AI
changed the title
[WIP] Handle existing folders
fix: handle EEXIST error when creating directories in parallel with node-to-fsa adapter
Oct 1, 2025
Contributor
|
🎉 This PR is included in version 4.48.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When calling
getDirectoryHandle()with{create: true}in parallel for the same folder, the Node.js to FSA adapter was throwing anEEXISTerror:This occurred because both parallel calls would:
statreturnsENOENT)mkdir)mkdirfails withEEXISTSolution
Modified
NodeFileSystemDirectoryHandle.getDirectoryHandle()to handle theEEXISTerror gracefully. WhenmkdirthrowsEEXISTduring directory creation:statTypeMismatchErroras beforeThis aligns with the File System Access API specification where creating a directory that already exists should succeed when using the
createoption.Changes
mkdirto handleEEXISTerrorTesting
Closes #97ba9c15-6996-496b-a9a0-a4699dbcd7ac
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.