Repository navigation
Conversation
liramon2
approved these changes
Sep 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4721.
Problem
Gemini sometimes sends a complete final response without usage metadata. Strands finishes the answer, then tries to read token counts from an object that is not there and crashes.
Fix
One condition:
if eventbecomesif event and event.usage_metadata is not None. If the counts object is absent, the stream finishes normally without inventing a zero count. If the object exists with empty counts, existing behavior is unchanged. No change to token calculations, finish reasons, formatting, requests, or provider calls.Tests
Three cases use real google.genai GenerateContentResponse objects parsed from JSON: two omitted-usage cases (STOP and SAFETY finish reasons) checking preserved answer text, expected stop reason, normal completed iteration, and no invented metadata; one empty-but-present usage object case protecting existing zero-count behavior. The client's response source is mocked only through the existing test fixture; the actual editable-checkout GeminiModel.stream and formatter run normally.
Before: 2 failed, 1 passed (the focused 3 cases). After: the full existing + new test_gemini.py passes, 78 tests in 1.22s. Python 3.10.12, pytest 9.1.1. Ruff check/format and git diff --check clean. No API requests, credentials, models, GPU, or broader integration-suite runs are claimed.
Credit: @abdes reported the issue.
Prepared with AI assistance (Instinct assisted).