Repository navigation
fix(commands): Export PDF and PNG without a path ask where to save - #2665
Merged
echelon merged 1 commit intoOct 18, 2026
Merged
Conversation
…torytold#2313) Signed-off-by: Charan Rathore <[email protected]>
Member
|
Landed, thank you! Export to PDF/PNG without a path now asks where to save, consistent with Save As. If you haven't already, come and join us on Discord: https://discord.gg/artcraft |
daghantektepe
added a commit
to daghantektepe/wordcraft
that referenced
this pull request
Nov 6, 2026
…NG without a path ask where to save tamamlandı
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2313.
Running
Export as PDF(or PNG) without apathargument used to fail withbad parameters: path (string) is required. Now the command asks where to save the file, like the other export commands do.The engine emits an
exportPdf/exportPngUI request when no path is given, and the UI opens the matching save dialog. Added regression tests for both commands.Test plan
file_dialogs.rs: export PDF/PNG without a path opens the save dialog (module suite 11/11 green)cargo test -p wordcraft-engine --lib: 618 passed, 0 failed