Skip to content

fix(commands): Export PDF and PNG without a path ask where to save - #2665

Merged
echelon merged 1 commit into
storytold:mainfrom
charan-rathore:fix/2313-export-pdf-ask-for-path
Oct 18, 2026
Merged

echelon merged 1 commit into
storytold:mainfrom
charan-rathore:fix/2313-export-pdf-ask-for-path

Conversation

@charan-rathore

Copy link
Copy Markdown
Contributor

Closes #2313.

Running Export as PDF (or PNG) without a path argument used to fail with bad parameters: path (string) is required. Now the command asks where to save the file, like the other export commands do.

The engine emits an exportPdf/exportPng UI request when no path is given, and the UI opens the matching save dialog. Added regression tests for both commands.

Test plan

  • New tests in file_dialogs.rs: export PDF/PNG without a path opens the save dialog (module suite 11/11 green)
  • cargo test -p wordcraft-engine --lib: 618 passed, 0 failed

@echelon
echelon merged commit 5b322e1 into storytold:main Oct 18, 2026
@echelon

echelon commented Oct 18, 2026

Copy link
Copy Markdown
Member

Landed, thank you! Export to PDF/PNG without a path now asks where to save, consistent with Save As.

If you haven't already, come and join us on Discord: https://discord.gg/artcraft

daghantektepe added a commit to daghantektepe/wordcraft that referenced this pull request Nov 6, 2026
…NG without a path ask where to save tamamlandı
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] [WordCraft] Export as PDF returns an error and does nothing

2 participants