Repository navigation
Keep pasted picture names unique, create atomic-write temp files exclusively, and keep distinct replay samples - #995
Merged
Merged
Conversation
Reserve temporary files exclusively with bounded collision retries, and only clean up a file reserved by the current write. Add focused regression fixtures. Automated validation is pending while the execution environment is unavailable.
Record the successful full Linux CI run for implementation 5f0f1ce. Mark the roadmap item complete and replace the pending validation note.
save_pasted_picture named files by millisecond timestamp only, so two pastes in the same millisecond collided, and a paste could reuse a name cleanup had just freed. Fold the inbox counter into the name (pasted-<ms>-<counter>.png) so names are unique within the process; create_new still guards two app copies. Co-authored-by: Qwen-Coder <[email protected]>
Retain collision, symlink, permissions and cleanup regressions alongside current upstream status entries.
Keep temporary names independent of the destination component, and apply Unix mode 0600 when private temporary files are created. Retain collision and cleanup coverage, and verify long valid names and permissions before later chmod calls.
Consecutive samples compare all response fields, keeping distinct headers, content types and omitted-body metadata. Add focused regression fixtures. Automated validation is pending while the execution environment is unavailable.
Record the successful full Linux CI run for implementation ec385c3. Mark the roadmap item complete and replace the pending validation note.
Record the successful full Linux gate and fourteen replay regressions. Keep this roadmap block and status row clear of the separate retained-budget change.
Expect no dropped sample when a repeated response is discarded before charging its bytes, at both the exact and remaining total-body budgets. Preserve the unavailable 304 evidence, replay assertions and remaining-budget assertions. Record the 24 passing combined regressions on the refreshed source and keep historical full-CI results scoped to their recorded revisions.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 6, 2026
bflatastic
added a commit
that referenced
this pull request
Nov 6, 2026
…them here (#1012) The squash messages of #987, #990, #992, #993, #994, #995, #996, #997, #999, #1001, #1002, #1003 and #1004 carried their co-authors as plain text or lost them, so GitHub credited nobody. This commit names them. Co-authored-by: Dev Maktuporia <[email protected]> Co-authored-by: Diego Valadez <[email protected]> Co-authored-by: Vincenzo Governali <[email protected]> Co-authored-by: d41sys <[email protected]> Co-authored-by: monarchsofchaos004-gif <[email protected]> Co-authored-by: anoscetia <[email protected]> Co-authored-by: 00xJ0 <[email protected]> Co-authored-by: Sanket Dofe <[email protected]> Co-authored-by: POJ <[email protected]> Co-authored-by: Afloat <[email protected]> Co-authored-by: SoldierPePe <[email protected]> Co-authored-by: justinjohn0306 <[email protected]> Co-authored-by: Tomáš Doubek <[email protected]> Co-authored-by: AlexJoaquimPereira <[email protected]> Co-authored-by: FuryNocturn <[email protected]> Co-authored-by: Aymen <[email protected]> Co-authored-by: jayzed80 <[email protected]> Co-authored-by: Huyvux12 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replays three PRs, keeping their authors' commits. #733's and #718's only failing CI runs were on tests fixed since (#732, #767), on bases too old to rerun.
Verified:
cargo test -p craft-anything-platform -p craft-anything-analysis, the engine's paste tests, clippy for those crates.Supersedes #733
Supersedes #718
Supersedes #716