Skip to content

Read concatenated Zstandard frames without dropping member data (R3.12) - #1340

Merged
bflatastic merged 3 commits into
storytold:mainfrom
Afloat16:bugfix/r3.12-zstandard-multiple-frames
Nov 9, 2026
Merged

bflatastic merged 3 commits into
storytold:mainfrom
Afloat16:bugfix/r3.12-zstandard-multiple-frames

Conversation

@Afloat16

@Afloat16 Afloat16 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

The streaming decoder finishes at the first frame, so a multi-frame member loses its suffix or fails the container's decoded-size/CRC check. Decode each frame into one capped output and advance across length-delimited skippable frames. Partial later frames produce an error.

The regression failed on main and passes with the change. Both complete frames are recovered, a combined-output cap is enforced, and truncated data frames and metadata frames are rejected. All nine decompressor and byte-reader tests plus the format, diff, layer and secret checks passed on Linux.

@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between ff2e872 and e319092.

Files selected for processing: 3

  • crates/formats/src/decompress.rs
  • docs/ROADMAP.md
  • docs/STATUS.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@bflatastic
bflatastic merged commit 25a8f17 into storytold:main Nov 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants