Skip to content

CLI: Remove REACT_PROJECT projectType #33334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yannbf merged 1 commit into from
Dec 10, 2025
Merged

CLI: Remove REACT_PROJECT projectType #33334

yannbf merged 1 commit into from
Dec 10, 2025
+0 −20

Conversation

@valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Dec 10, 2025 •
edited by coderabbitai bot
Loading

Closes #

What I did

As part of the CLI revamp project, the generator for the project type "REACT_PROJECT" was removed because it was identical to the one for the project type "REACT". I forgot to clean up the related projectType detection logic, which is now done in this PR!

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Changes
    • Removed support for React project type detection and onboarding. React projects will no longer be recognized or supported through the automatic detection flow.

✏️ Tip: You can customize this high-level summary in your review settings.

@valentinpalkovic valentinpalkovic self-assigned this Dec 10, 2025
@nx-cloud
Copy link

nx-cloud bot commented Dec 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 589e0b2

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ✅ Succeeded 10m 36s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-10 20:27:15 UTC

@nx-cloud
Copy link

nx-cloud bot commented Dec 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 589e0b2

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ✅ Succeeded 10m 36s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-10 20:27:09 UTC

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

📝 Walkthrough

Walkthrough

This pull request removes support for the REACT_PROJECT project type from the Storybook codebase. The enum member is deleted from the ProjectType definition, and all related references—including feature compatibility settings, template configurations, and associated tests—are removed.

Changes

Cohort / File(s) Summary
Type Definition
code/core/src/cli/projectTypes.ts		 Removed REACT_PROJECT = 'react_project' enum member from ProjectType
Feature & Compatibility Services
code/lib/create-storybook/src/services/FeatureCompatibilityService.ts, code/lib/create-storybook/src/services/ProjectTypeService.ts		 Removed ProjectType.REACT_PROJECT from ONBOARDING_PROJECT_TYPES and deleted its TemplateConfiguration entry with associated peer dependency matcher
Tests
code/lib/create-storybook/src/services/ProjectTypeService.test.ts		 Deleted test case validating REACT_PROJECT detection via peerDependencies

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • All changes are straightforward removals with no new logic or complex structural edits
  • Changes are consistent in pattern across multiple files (same member/reference removal)
  • Test deletion is minimal and clearly scoped
  • Primary consideration: verify no other code paths depend on the removed enum member outside these files

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cfe4488 and 589e0b2.

📒 Files selected for processing (4)
  • code/core/src/cli/projectTypes.ts (0 hunks)
  • code/lib/create-storybook/src/services/FeatureCompatibilityService.ts (0 hunks)
  • code/lib/create-storybook/src/services/ProjectTypeService.test.ts (0 hunks)
  • code/lib/create-storybook/src/services/ProjectTypeService.ts (0 hunks)
💤 Files with no reviewable changes (4)
  • code/lib/create-storybook/src/services/FeatureCompatibilityService.ts
  • code/core/src/cli/projectTypes.ts
  • code/lib/create-storybook/src/services/ProjectTypeService.test.ts
  • code/lib/create-storybook/src/services/ProjectTypeService.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: normal
  • GitHub Check: nx
  • GitHub Check: Danger JS
  • GitHub Check: nx
  • GitHub Check: Core Unit Tests, windows-latest

Comment @coderabbitai help to get the list of available commands and usage tips.

@yannbf yannbf merged commit 23b7191 into next Dec 10, 2025
74 of 83 checks passed
@yannbf yannbf deleted the valentin/remove-react-project-project-type branch December 10, 2025 22:24
@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 10, 2025
This was referenced Dec 10, 2025
Merged
Closed
Open
valentinpalkovic pushed a commit that referenced this pull request Dec 11, 2025
@yannbf @storybook-bot
Merge pull request #33334 from storybookjs/valentin/remove-react-proj…
20117a7 
…ect-project-type

CLI: Remove REACT_PROJECT projectType
(cherry picked from commit 23b7191)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yannbf yannbf yannbf approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels

bug ci:normal cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@valentinpalkovic @yannbf