-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
CSF: Export type to prevent type cannot be named-errors
#33216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This address the "type cannot be named" error for `defineMain()`.
Fix `meta.story()` type cannot be named error
|
View your CI Pipeline Execution ↗ for commit d3704dd
☁️ Nx Cloud last updated this comment at |
|
You can see the patch that fixed the issue here: https://github.com/cyberuni/sb-composite/tree/issues-32898-patch |
|
Also fixes #30579 :) |
| export function defineMain(config: StorybookConfig) { | ||
| return config; | ||
| } | ||
|
|
||
| export type { StorybookConfig }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we explicitly stated the return type, would the type export still be needed? @kasperpeulen
type cannot be named-errors
📝 WalkthroughWalkthroughThis change expands the public type surface across addon and framework modules by adding new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
✨ Finishing touches
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (16)
🧰 Additional context used📓 Path-based instructions (5)**/*.{js,jsx,json,html,ts,tsx,mjs}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
code/**/*.{ts,tsx,js,jsx,mjs}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
code/**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
code/**/*.{js,jsx,json,html,ts,tsx,mjs}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
🧠 Learnings (10)📓 Common learnings📚 Learning: 2025-09-24T09:39:39.233ZApplied to files:
📚 Learning: 2025-11-05T09:38:47.712ZApplied to files:
📚 Learning: 2025-11-28T14:50:24.872ZApplied to files:
📚 Learning: 2025-09-18T20:51:06.618ZApplied to files:
📚 Learning: 2025-09-18T20:51:06.618ZApplied to files:
📚 Learning: 2025-11-28T14:50:24.872ZApplied to files:
📚 Learning: 2025-11-28T14:50:24.872ZApplied to files:
📚 Learning: 2025-09-29T13:20:23.346ZApplied to files:
📚 Learning: 2025-11-05T09:37:25.920ZApplied to files:
🧬 Code graph analysis (1)code/core/src/viewport/preview.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (14)
Comment |
Fix type cannot be named error for
defineMain()andmeta.story()Closes #32898
What I did
Re-export missing types
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Not in automated tests, Couldn't find a way to generate the build result (not the pseudo dist in the monorepo) to test against.
Manual testing
The one for
defineMainis pretty easy to validate.The global types I cannot fully vet it as it depends on the final build tool.
But it should work. I tested it directly in the resulting
dist/index.d.ts.The issue can be repro (and tested manually in):
https://github.com/cyberuni/sb-composite
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.