Merged
Conversation
olizilla
approved these changes
May 18, 2023
Contributor
olizilla
left a comment
olizilla
left a comment
There was a problem hiding this comment.
Change looks good 👍
UnknownLink is too much abstraction / verbose for me
alanshaw
pushed a commit
that referenced
this pull request
May 18, 2023
🤖 I have created a release *beep* *boop* --- ## [7.0.0](v6.0.2...v7.0.0) (2023-05-18) ### ⚠ BREAKING CHANGES * remove search option ([#23](#23)) * rename dagScope to carScope ([#21](#21)) ### Features * add ordering option to getPath ([#19](#19)) ([ad25001](ad25001)) * support yamux muxer ([#11](#11)) ([24ef997](24ef997)) ### Bug Fixes * rename dagScope to carScope ([#21](#21)) ([497cc90](497cc90)) ### refactor * remove search option ([#23](#23)) ([9ede86f](9ede86f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the internal
searchoption in favour of a blockfilteroption.I also fixed all the types in
index.js...was having a hard time withLinkvsCIDand decided to upgrade everything to useLink, seeing as this is going out as a breaking change anyway.