Merged
Conversation
karol-maciaszek
changed the title
karol-maciaszek
changed the title
This was referenced Oct 29, 2019
XVincentX
reviewed
Oct 31, 2019
XVincentX
approved these changes
Nov 4, 2019
Contributor
XVincentX
left a comment
XVincentX
left a comment
There was a problem hiding this comment.
This is ok but let's wait for somebody else to make sure they're ok with the changes.
Collaborator
|
🎉 This PR is included in version 11.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces an IHttpOperation extension called IHttpCallbackOperation. The new interface carries additionally the name of callback operation.
The motivation behind extending the interface: callbacks in OASv3 spec are wrapped in an object with callback name as property and operation as value. SL's way of representing such objects is to convert it to an array and add a property inside with the key name (see operations array, examples array, etc.). This change is compatible with that approach.
Related PR: stoplightio/prism#716
Related issue: stoplightio/prism#331
The spec: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#callbackObject
Callback example: https://github.com/OAI/OpenAPI-Specification/blob/master/examples/v3.0/callback-example.yaml