Improve WebHooks calling chain#772
Merged
karol-maciaszek merged 3 commits intofeat/webhooksfrom Nov 6, 2019
Merged
Conversation
karol-maciaszek
approved these changes
Nov 6, 2019
Contributor
karol-maciaszek
left a comment
karol-maciaszek
left a comment
There was a problem hiding this comment.
Couldn't agree more 👍
XVincentX
pushed a commit
that referenced
this pull request
Nov 6, 2019
* feat: runtime expressions resolver * chore: bits of callback implementation * chore: refactored forwarder * chore: callback improvements * fix: linting * test: part of tests * test: mocker tests, various fixes * chore: improvements in runtime expressions * fix: further runtimeExpressions improvements * chore: more changes in runtimeExpressions * chore: renamed util/response to utils/parseResponse * fix: improved typing * fix: auto-generation of content-type for callback request * fix: fixed generation of content-type header * feat: added callback example * docs: improved callbacks documentation * docs: further docs improvements * fix: test description fixes * fix: added comment to runtime expressions * chore: code style * fix: improvements on runtimeExpressions * fix: removed left-over * fix: adjusted callbacks to recent validator refactor * fix: typing fix * fix: type fixes * fix: improved test types * fix: more specific types * feat: introduced assertResolvesLeft and assertResolvesRight helper functions * chore: better den for fp assertion helpers * fix: improved fp usage * Improve WebHooks calling chain (#772) * refactor: unknown error * format: mardkwon file * refactor: improve chain call * docs: added callbacks limitations section * fix: param generator input update * docs: docs improvements * docs: add comment * fix: more verbose error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a lot of formatting because of eslint, but the relevant bits are here: https://github.com/stoplightio/prism/compare/feat/webhooks...feat/webhook-improvements?expand=1#diff-91872759342de667324152b94a1fc424L27