feat: pass maxRefDepth to tree to limit recursion#243
Merged
daniel-white merged 1 commit intomasterfrom Nov 15, 2023
Merged
Conversation
daniel-white
requested review from
a team and
mallachari
and removed request for
a team
daniel-white
force-pushed
the
feat/limit-recursion
branch
from
8512e3e to
2989f11
Compare
EdVinyard
approved these changes
Nov 15, 2023
Contributor
EdVinyard
left a comment
EdVinyard
left a comment
There was a problem hiding this comment.
I had only one question, but this looks reasonable to me.
| const jsonSchemaTree = new JsonSchemaTree(schema, { | ||
| mergeAllOf: true, | ||
| refResolver: resolveRef, | ||
| maxRefDepth, |
Contributor
There was a problem hiding this comment.
Is it correct that JsonSchemaTree already had an optional maxRefDepth parameter, and this PR just allows the caller to specify that when instantiating a JsonSchemaViewer component? (And if it's not specified, there's no limit?)
Author
There was a problem hiding this comment.
it did not have the parameter, i added it and didn't set a limit for backwards compatability
Collaborator
|
🎉 This PR is included in version 4.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrade json-schema-tree and pass the new option around