Skip to content

Comments

Remove minified dist files#648

Merged
marcoroth merged 3 commits intomainfrom
remove-minified-dist-files
Mar 24, 2023
Merged

Remove minified dist files#648
marcoroth merged 3 commits intomainfrom
remove-minified-dist-files

Conversation

@marcoroth
Copy link
Member

Type of PR

Simplification

Description

In a world where JavaScript bundling in the Ruby on Rails landscape is being pushed more and more towards the developer itself it should also be up to them how, why and if they bundle/minify/compress their (JavaScript) assets. So it's becoming more and more irrelevant for NPM packages and gems to ship both regular and minified+map dist files if they are never/rarely needed.

Following up on stimulusreflex/cable_ready#271

Why should this be added

This brings a few benefits:

  • Reduces the npm package size and shipped number of files inside the package
  • Reduces the gem size and shipped number of files inside the gem
  • Reduces the amount of assets to be precompiled in the Rails assets pipeline, if you haven't actively excluded them.
  • Reduces the build time for building the library when running yarn build
  • Make it easier for us to maintain because there are less files which are needed to get built
  • Makes it easier to debug, because the error messags refer to line-numers, rather then line number 1 in a minified file

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing

@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for stimulusreflex ready!

Name Link
🔨 Latest commit d860f49
🔍 Latest deploy log https://app.netlify.com/sites/stimulusreflex/deploys/641cad931c8cf5000795cfc1
😎 Deploy Preview https://deploy-preview-648--stimulusreflex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@marcoroth marcoroth merged commit dc813d4 into main Mar 24, 2023
@marcoroth marcoroth deleted the remove-minified-dist-files branch March 24, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants