Add .rake to gemspec files glob pattern#581
Merged
leastbad merged 1 commit intostimulusreflex:masterfrom Apr 21, 2022
Merged
Conversation
3 tasks
marcoroth
added a commit
that referenced
this pull request
Jul 29, 2022
The `.js.tt` and `.rb.tt` were missing in the bundled and published gem. Follow up of #581
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR
Bug Fix
Description
In the process of releasing
3.5.0.pre9we harmonized thegemspecfilesglob pattern with the one of CableReady. In that process we changedlib/**/*tolib/**/*.rband with that losing the inclusion of theinstall.rakefile. This one is needed in order to run the install rake task.Why should this be added
This PR adds the
.rakefile extension to thefilesglob pattern in the gemspec so that theinstall.rakefile is included in the bundled gem again.Checklist