Improve install experience#510
Merged
leastbad merged 21 commits intostimulusreflex:masterfrom Jul 19, 2021
Merged
Conversation
marcoroth
reviewed
May 23, 2021
marcoroth
reviewed
May 23, 2021
Member
marcoroth
left a comment
There was a problem hiding this comment.
Nice! I really like the overall improvements done here 👍🏼
marcoroth
reviewed
May 23, 2021
Co-authored-by: Marco Roth <[email protected]>
Co-authored-by: Marco Roth <[email protected]>
Contributor
KonnorRogers
left a comment
There was a problem hiding this comment.
In my brief attempts to break this, it held up pretty well. Default urls not being set isnt currently firing. I suggested a fix. Other than that, this feels pretty solid.
Co-authored-by: Konnor Rogers <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Bug fix
Description
It doesn't seem like the sanity check modules receive anything in the
ARGV, and since it's basically impossible to obtain the CLI command used to run the rake task, I suspect that thecalled_by_generate_config?method isn't doing anything.I came up with an admittedly hacky but seemingly effective way to determine if the sanity check is being run inside of rake:
I have been able to verify that installation works great on a fresh Rails 6.1 project.
I also took the opportunity to freshen up the copy offered by the warning messages. I found it a bit hard to read.
Fixes #508
Install task needs to be rock solid.
Checklist