Merged
Conversation
The most important changes: add class options add tests add default values for prompts change generator name from `cable_ready_channel` to `cable_ready:channel`
update cable_ready channel generator
hopsoft
approved these changes
Feb 2, 2021
Contributor
hopsoft
left a comment
hopsoft
left a comment
There was a problem hiding this comment.
Should we add details like the --stream-for and --stream-from options to the USAGE doc? Looks like there's a merge conflict, but I'm good for this to merge whenever you're ready once conflicts are resolved.
Contributor
Author
|
@marcoroth assured me that those details are going to be added automatically when you invoke —help |
Contributor
Author
|
Good to go! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a generator that will provide a "batteries included" cable ready channel.
This will:
ActionCablegeneratorstream_tocall to thechannel.rbcontrollersdirectory is presentstream_forintochannel.rbif (data.cableReady) CableReady.perform(data.operations)into thechannel.jsfile, plus importI wanted to also include a test, but failed at mocking STDIN with
StringIOCloses #94