Isolate and namespace CableReady::Installer#295
Merged
Conversation
✅ Deploy Preview for cableready ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
marcoroth
added a commit
to stimulusreflex/stimulus_reflex
that referenced
this pull request
May 6, 2024
This pull request isolates the methods defined `lib/stimulus_reflex/installer.rb` into a `StimulusReflex::Installer` constant so they don't pollute the global namespace if the file is required. CableReady got a similar PR: stimulusreflex/cable_ready#295 ## Why should this be added Exposing all the methods from the installer in the global namespace could lead to issues down the road. Methods like `options` are likely to be overridden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR
Enhancement
Description
This pull request isolates the methods defined
lib/cable_ready/installer.rbinto aCableReady::Installerconstant so they don't pollute the global namespace if the file is required.Why should this be added
Exposing all the methods from the installer in the global namespace could lead to issues down the road. Methods like
optionsare likely to be overridden.Checklist