Wrap updates-for-element in an IntersectionObserver#285
Merged
julianrubisch merged 6 commits intomainfrom Nov 9, 2023
Merged
Conversation
✅ Deploy Preview for cableready ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
This type of optimization is 🤌 Very nice work here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Description
This PR addresses an optimization regarding the number of requests that
Updatablepossibly makes.The rationale is this: it doesn't really make sense to keep elements that aren't visible up to date. this can be deferred, which defaults to lazy loading.
We have to distinguish 3 cases here:
Implementation
I leaned on Turbo's solution here a bit, and introduced a separate
AppearanceObserver. The thing I added to the regularIntersectionObserveris an observer fordocument.visibilityState. This means:will not trigger updates. When they come into view, e.g. by scrolling into the viewport, or switching browser tabs, they will perform a one-time update and then continue listening as normal.
In terms of view helpers, I only added an
observe_appearanceflag to keep this optional. The element will then observe both behaviors though.