Set xpath flag if/when overwriting selector with previous_selector#278
Merged
julianrubisch merged 2 commits intostimulusreflex:mainfrom Jun 30, 2023
Merged
Conversation
✅ Deploy Preview for cableready ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
marcoroth
reviewed
May 30, 2023
Member
marcoroth
left a comment
There was a problem hiding this comment.
Thank you for taking this one on @Matt-Yorkley!
b107e22 to
cf5094a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
Description
When chaining operations that use a
selectorargument, subsequent operations can optionally omit theselectorargument and theselectorfrom the previous operation gets applied applied automatically (at line 46 ofCableReady::OperationBuilderhere.There's a weird edge case here that can cause the subsequent operation to fail if the first operation was using
xpath, because theselectorargument gets set but thexpathargument does not get set and defaults tofalse, eg:The first operation is applied correctly but the
inner_htmloperation fails to find it's element, as it hasselector: "/html/body/div[1]", xpath: false, resulting in:The DOM element isn't missing, it's just not being looked for with
xpath.Why should this be added
Fixes an obscure edge case when chaining operations using xpath selectors and omitting the selector in subsequent operations.
Checklist