Conversation
✅ Deploy Preview for cableready ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
2 tasks
hopsoft
approved these changes
Mar 23, 2023
marcoroth
added a commit
to stimulusreflex/stimulus_reflex
that referenced
this pull request
Mar 24, 2023
## Description In a world where JavaScript bundling in the Ruby on Rails landscape is being pushed more and more towards the developer itself it should also be up to them how, why and if they bundle/minify/compress their (JavaScript) assets. So it's becoming more and more irrelevant for NPM packages and gems to ship both regular and minified+map dist files if they are never/rarely needed. Following up on stimulusreflex/cable_ready#271 ## Why should this be added This brings a few benefits: - Reduces the npm package size and shipped number of files inside the package - Reduces the gem size and shipped number of files inside the gem - Reduces the amount of assets to be precompiled in the Rails assets pipeline, if you haven't actively excluded them. - Reduces the build time for building the library when running `yarn build` - Make it easier for us to maintain because there are less files which are needed to get built - Makes it easier to debug, because the error messags refer to line-numers, rather then line number 1 in a minified file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR
Simplification
Description
In a world where JavaScript bundling in the Ruby on Rails landscape is being pushed more and more towards the developer itself it should also be up to them how, why and if they bundle/minify/compress their (JavaScript) assets. So it's becoming more and more irrelevant for NPM packages and gems to ship both regular and minified+map dist files if they are never/rarely needed.
Why should this be added
This brings a few benefits:
yarn buildChecklist