Set default debounce time in CableReady::Config#263
Merged
julianrubisch merged 4 commits intomainfrom Mar 2, 2023
Merged
Conversation
✅ Deploy Preview for cableready ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
marcoroth
reviewed
Mar 1, 2023
Member
marcoroth
left a comment
marcoroth
left a comment
There was a problem hiding this comment.
@julianrubisch looks good to me! Could you add a test for it? I recently added #254 which should be super straightforward.
Contributor
Author
I wanted to, but it introduces a race condition which sometimes breaks updatable tests 😕 |
Member
|
Could we resolve that with a similar helper method we added in StimulusReflex? |
Contributor
Author
|
I’ll give it a try! |
Contributor
Author
|
Splendid! 🙌 @hopsoft this also allows us to leave the default debounce time at 0.1 seconds |
hopsoft
requested changes
Mar 2, 2023
marcoroth
reviewed
Mar 4, 2023
Comment on lines
+22
to
+26
|
|
||
| # Specify a default debounce time for CableReady::Updatable callbacks | ||
| # Doing so is a best practice to avoid heavy ActionCable traffic | ||
| # | ||
| # config.updatable_debounce_time = 0.1.seconds |
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement
Description
Allows to set the default
updatable_debounce_timein the CableReady config. This allows every application to set it to a desired valueChecklist