Conversation
✅ Deploy Preview for cableready ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This solves #258 for me 🙇 |
hopsoft
approved these changes
Mar 2, 2023
| raise ArgumentError, "Could not find inverse_of for #{collection[:name]}" unless collection[:inverse_association] | ||
| collection.reflection ||= collection.klass.reflect_on_association(collection.name) | ||
|
|
||
| collection.foreign_key ||= collection.reflection.foreign_key |
Contributor
There was a problem hiding this comment.
We use safe navigation below on collection.reflection. Should we do the same here?
…/cable_ready into fix-inverse-of-resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
Description
This is more or less a reimplementation of a patch that @andrewculver made to fix
inverse_ofresolution. I just took it a bit further and lazy loaded/stored reflection properties in the finder, because it's useless to do the work twice, and declutters the main module a bithttps://github.com/stimulusreflex/cable_ready/compare/master...andrewculver:cable_ready:master?diff=split
(maybe) Fixes #258
awaiting confirmation from the BulletTrain team cc @andrewculver
Checklist